Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR - Make use of the .yml file for pattern data #1

Closed
2 of 3 tasks
sturobson opened this issue Nov 7, 2018 · 5 comments
Closed
2 of 3 tasks

REFACTOR - Make use of the .yml file for pattern data #1

sturobson opened this issue Nov 7, 2018 · 5 comments
Assignees
Labels

Comments

@sturobson
Copy link

sturobson commented Nov 7, 2018

At the moment most, if not all, patterns have 'hard coded' content/data into the patterns .hbs file.

To make it easier for developers using the visual framework it would be better to move any of this content/data to the .yml file that each component has.

  • remove all 'hard coded' content/data from patterns and put it into data
  • make use of {{> '@component'}} rather than {{render '@component'}}
  • add documentation about how to add content/data for a pattern within a pattern

questions:

do we want to start making use of any handlebars sugar for {{each}} for anything like lists?

@sturobson sturobson self-assigned this Nov 7, 2018
@sturobson sturobson changed the title make use of the .yml file for pattern data 1: make use of the .yml file for pattern data Nov 7, 2018
@sturobson sturobson changed the title 1: make use of the .yml file for pattern data 1: Make use of the .yml file for pattern data Nov 7, 2018
@sturobson sturobson changed the title 1: Make use of the .yml file for pattern data 1: Make use of the .yml file for pattern data Nov 7, 2018
@sturobson sturobson changed the title 1: Make use of the .yml file for pattern data Make use of the .yml file for pattern data Nov 7, 2018
@sturobson
Copy link
Author

sturobson commented Nov 7, 2018

I have added the fractal handlebars helpers dependency.

Along with this I have added a simple {{#equals}} handlebars helper to loop through key: value pairs and determine a better 'if else'.

It would be nice if we get the helper to include an {{else}} but it's not important right now

@sturobson sturobson changed the title Make use of the .yml file for pattern data REFACTOR - Make use of the .yml file for pattern data Nov 8, 2018
@khawkins98 khawkins98 added this to the v2.0.0-alpha.3 milestone Jan 22, 2019
@khawkins98
Copy link
Contributor

Where do we stand on this one? I think we've started putting some data into the .ymls, I guess this one is more of a chore/cleanup now? Or do we still have architecture work to do?

@sturobson
Copy link
Author

Yes, I had a branch for this (I might have committed it, if not it's lost in the MacBook move).

This could be one for me to pick up when it's trains, planes, and automobiles when I travel back to the UK on Friday

@khawkins98 khawkins98 removed this from the v2.0.0-alpha.4 milestone Mar 14, 2019
@sturobson
Copy link
Author

I'm closing this one as it's moved to #316 for the Beta release

@khawkins98
Copy link
Contributor

315 issues later 😭 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants