Bug/load vf-core version directly from node_modules/vf-core
#539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't directly impact vf-core, but is a config issue in sites that use vf-core as a dependency. In short, it resulted in the vf-core version being reported as the client version.
|
Thank you for requesting a review for this pull request (PR). If you have not done so already - please fill out the PR description with as much context as possible. Pull request reviewBefore your PR can be merged in, it will need to be reviewed.
|
|
Do we need to put this Now, soon, somewhen in the future? |
|
Yeah, def need to make it re-usable/componentised. Still trying to get a feel for how we should best do it; currently debating:
It's probably #1, I just need to get on it. Would be good to have that done before the demo next week. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wasn't directly impacting vf-core, but is a config issue in sites that use vf-core as a dependency. In short, it resulted in the vf-core version being reported as the client version.