Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The one that refactors, enhances, and starts to deprecate some things for the vf-card. #1255

Merged
merged 6 commits into from
Nov 25, 2020

Conversation

sturobson
Copy link

From the changelog:

  • adds new --bordered and --striped design variants.
  • added vf-stack to the vf-card__content element to determine spacing.
  • allows for the lack of vf-stack for older components.
  • started the deprecation of the 'Mortal Kombat' variants, initally by hiding them in vf-core.
  • introduced newTheme so the 'Mortal Kombat' variants can live side-by-side with news versions for now.
    • the newTheme moves us back to the 'primary' being the embl green, the secondary the embl blue, etc.
    • we now remove the -theme part of the css class moving forward as it's cleaner, easier to read, and states the same thing without it.
  • created theme variants of the new design variants (these are hidden, and should not be used).

@sturobson
Copy link
Author

The only two cards - that should be used for the short future:

vf-card--bordered
Screenshot 2020-11-25 at 09 37 42

vf-card--striped
Screenshot 2020-11-25 at 09 37 34

@khawkins98
Copy link
Contributor

As an aside: I wonder if we should change the example image, as the "blobs" are no longer favoured.

@sturobson
Copy link
Author

I've updated the example image for the cards, using an image from emb.org/files now:

Screenshot 2020-11-25 at 10 09 09
Screenshot 2020-11-25 at 10 08 59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants