Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: swap vf-core dev theme to mandlebrot #1262

Merged
merged 1 commit into from
Nov 27, 2020

Conversation

khawkins98
Copy link
Contributor

Following conversations in #1260 and #1261, we don't really need a custom fractal theme anymore. This swaps back to the default theme for vf-core development.

It also removes the vf-frctl-theme (which could still be resurrected from npm, if needed)

Following conversations in #1260 and #1261, we don't really need a custom fractal theme anymore. This swaps back to the default theme for vf-core development.

It also removes the vf-frctl-theme (which could still be resurrected from npm, if needed)
Copy link

@sturobson sturobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick typing

@sturobson sturobson merged commit a6e14b2 into develop Nov 27, 2020
@sturobson sturobson deleted the chore/swap-to-mandlebrot branch November 27, 2020 09:52
@sturobson
Copy link

tried this - and I'm still getting the custom theme - with it error'ing when clicking on a component.

Doing this in fractal.js fixed it:

// var vfThemePath = global.vfThemePath || '@frctl/mandelbrot';
const vfTheme = require('@frctl/mandelbrot');

is my

git fetch origin
git reset --hard origin/develop

along with sprinkles of git clean fed beforehand not working properly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants