Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the one that fixes tiny transitional bug with card titles #1267

Merged
merged 1 commit into from
Nov 27, 2020
Merged

the one that fixes tiny transitional bug with card titles #1267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions components/vf-card/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
### 2.3.1

* issue with margin-bottom still in place when using `vf-stack` with `vf-card__content`.

### 2.3.0

* adds new `--bordered` and `--striped` design variants.
Expand Down
1 change: 1 addition & 0 deletions components/vf-card/vf-card.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,7 @@
// note: as we are adding `vf-stack` to the `vf-card__content` we need to override
// the existing `margin-bottom` to the `__title` and __text` components.
.vf-card__content.vf-stack {
.vf-card__title,
.vf-card__text {
margin-bottom: 0;
}
Expand Down