Bug: vf-hero loop #1462
Merged
Bug: vf-hero loop #1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current vf-hero.njk will error if receive a `vf_hero_text` from a yaml file under certain contexts. This: - fixes the above - Allows vf_hero_heading_href to be passed in yaml - Gobbles much of the whitespace
|
Deploy preview for ecstatic-noether-150ab4 ready! Built with commit 0577556 https://deploy-preview-1462--ecstatic-noether-150ab4.netlify.app |
sturobson
approved these changes
Mar 30, 2021
|
Deploy preview for ecstatic-noether-150ab4 ready! Built with commit af48746 https://deploy-preview-1462--ecstatic-noether-150ab4.netlify.app |
|
I like whitespace 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while helping update the static-html-pages: the current vf-hero.njk will error if receive a
vf_hero_textfrom a yaml file under certain contexts.This:
FYI @kasprzyk-sz