Component: vf-dropdown #1679
Component: vf-dropdown #1679
Conversation
|
✔️ Deploy Preview for ecstatic-noether-150ab4 ready! 🔨 Explore the source changes: 1b3a79a 🔍 Inspect the deploy log: https://app.netlify.com/sites/ecstatic-noether-150ab4/deploys/61531dc61aa11c0007fb8bc6 😎 Browse the preview: https://deploy-preview-1679--ecstatic-noether-150ab4.netlify.app |
|
Note that I added z-index metadata for variables, but couldn't get it working, so hardcoded values as of now. @khawkins98 do we have to run any command to compile these yaml values into scc/css? |
Yeah, to get the design tokens to update you need to:
That will compile them and make them available. The updated files need to be committed. Looking around the code I don't think these steps were ever documented — I'll add that to my to-do list. |
About should be one short sentence.
|
@nitinja is it possible to see some screenshots/visuals for this? |
|
HI @khawkins98 fixed review comments except one |
…amework/vf-core into components/vf-dropdown
|
I've also compiled the tokens and pushed those. |
Following work in #1682 and #1679 to introduce the new alpha components this cleans up a pair of rough edges. - css custom prop usage - ie11 fallback - njk typo - njk whitespace control - add aria progress bar role - maybe more work to do there in the future https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_progressbar_role - add context conditionals
* chore: drop-down and progress component cleanup Following work in #1682 and #1679 to introduce the new alpha components this cleans up a pair of rough edges. - css custom prop usage - ie11 fallback - njk typo - njk whitespace control - add aria progress bar role - maybe more work to do there in the future https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_progressbar_role - add context conditionals * Update vf-progress-indicator.jsx * CSS linting and nesting * More linting * Use z-index tokens, context * Small typo fixes * Remove unused event handler
|
thanks |
Initial commit for vf-dropdown, issue #1299