Issue1840-1842 : Changes to hide section header and add white backgro… #1851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…und to container - Added the class vf-u-sr-only to section header in case hidden - Components.njk updated with code to show example for type=container - Added example and put white background in container config
✅ Deploy Preview for tubular-strudel-7ad396 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@sandykadam Please review the PR and let me know if any changes are needed. |
|
@bhushan-ebi Please update the changelog file as we are making changes in the component, so we need to write in short what changes are coming in the new version. This will get displayed to users in the changelog. See this for example - https://github.com/visual-framework/vf-core/pull/1785/files |
|
@sandykadam Changelog.md file updated to show the changes. Please review. |
sandykadam
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…und to container