Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated : Issue 1978 - Changes to footer based on intranet implemen… #2113

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Updated : Issue 1978 - Changes to footer based on intranet implemen… #2113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc428c8
Updated : Issue 1978 - Changes to footer based on `intranet` implemen…
bhushan-ebi Aug 27, 2024
a7b9c52
Updated : Issue 1978 - Changes to footer based on `intranet` implemen…
bhushan-ebi Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions components/vf-footer/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
### 1.2.1

* Changes to footer based on `EMBL-EBI Intranet` implementation findings [Tracking issue](https://github.com/visual-framework/vf-core/issues/1978)

### 1.2.0

* Requires at least `@visual-framework@vf-sass-config@2.6.1`.
Expand Down
4 changes: 2 additions & 2 deletions components/vf-footer/vf-footer.njk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,8 @@
</li>
</ul>
<p class="vf-footer__legal-text">Copyright © Your Organisation.</p>
<p class="vf-footer__legal-text">Maybe an address too, 5555, Somewhere, Earth.</p>
<p class="vf-footer__legal-text">Tel: +49 00 000 000.</p>
<a class="vf-footer__link" href="{{ footer__url }}">Maybe an address too, 5555, Somewhere, Earth.</a>
<a class="vf-footer__link" href="{{ footer__url }}">Tel: +49 00 000 000.</a>
<a class="vf-footer__link" href="{{ footer__url }}">Another entry</a>
</section>
</div>
Expand Down
32 changes: 31 additions & 1 deletion components/vf-footer/vf-footer.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,8 @@

.vf-footer__legal-text,
.vf-footer__link {
padding-top: 12px;
padding-top: 6px;
padding-bottom: 6px;
}

@media (min-width: $vf-breakpoint--lg) {
Expand Down Expand Up @@ -118,6 +119,7 @@
border-width: 1px 0;
margin-bottom: 12px;
padding-bottom: 24px;
grid-template-columns: repeat(5, 1fr);

.vf-links__heading {
@include set-type(text-body--6, $custom-margin-bottom: 8px, $color: ignore);
Expand Down Expand Up @@ -197,3 +199,31 @@
}
}
}

@media (max-width: 768px) {

.vf-footer__links-group {
grid-template-columns: repeat(3, 1fr);

.vf-list__item {
padding-top: 10px;
padding-bottom: 10px;
}
}

.vf-footer__legal .vf-footer__legal-text, .vf-footer__legal .vf-footer__link {
padding-top: 14px;
padding-bottom: 14px;
}

.vf-footer .vf-grid {
grid-row-gap: 0rem;
}
}

@media (max-width: 600px) {

.vf-footer__links-group {
grid-template-columns: repeat(1, 1fr);
}
}