Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cascading Filter does not work with "Swiss PRTR (Test03)" #328

Closed
ortnever opened this issue Feb 4, 2022 · 2 comments · Fixed by #343
Closed

Cascading Filter does not work with "Swiss PRTR (Test03)" #328

ortnever opened this issue Feb 4, 2022 · 2 comments · Fixed by #343
Assignees
Labels
bug Something isn't working

Comments

@ortnever
Copy link

ortnever commented Feb 4, 2022

@ptbrowne : il s'agit du bug communiqué par Email le 28.01.

Filtre en cascade ne fonctionne pas pour PRTR (Test03)"

Steps to reproduce the behavior:

  1. Rechercher PRTR via test.visualize, y compris Draft
  2. Ouvrir « Registre suisse des rejets et transferts de polluants Swiss PRTR (Test03) »
  3. Choisir Bar chart (pas de données, pour l’ordre des filtres affichés par défaut)
  4. Choisir Etablissement comme segmentation (couleurs) et Modifier l’ordre des filtres comme printscreen ci-dessous
  5. Un graphique s’affiche par défaut
  6. Modifier le polluant et choisir "Chloride"
  7. Pas de données, alors qu’il en existe si on choisit comme activité « nicht aufgeschlüsselt ».

Expected behavior
la valeur "nicht aufgeschlüsselt" devrait être sélectionnée automatiquement dans le filtre "Activité principale" et des données seraient ainsi disponibles

image

image

image

@ortnever ortnever added the bug Something isn't working label Feb 4, 2022
@ptbrowne ptbrowne self-assigned this Feb 4, 2022
@ptbrowne
Copy link
Collaborator

ptbrowne commented Feb 4, 2022

Thanks for the report Véronique, I was not able to work on it before. I can reproduce correctly. I think I can improve the filter selection, and will work on this today. At the same time I think we can see that the current cascading filters do improve the existing product and that the functional bug that you describe would have been even harder to solve with the current production filters. In this sense, I think this bug should not block a production deploy as it its criticity is not IMHO high since:

  • The state before was worse
  • The user can work around the problem

@sosiology
Copy link
Contributor

  • A chart is now shown when the Pollutant is changed to Chloride.
  • The main activity shown is "Abfall- und Abwasserbewirtschaftung" (as oppose to "nicht aufgeschlüsselt" when the pollutant is changed but no error is shown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants