Improve filter value selection #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bprusinowski
approved these changes
Feb 14, 2022
Otherwise, dataset is not selected but were are still on a /create page and this causes a glitch when using the research
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when changing a filter in a cascading facets. we would take the first value of each dimension value that was present and this could lead to dead-end, and was slow since each filter could be changed after the filter just before it has been changed. Now the approach is different: when a filter is changed/moved, we try to find an observation with the filter, and if we do not find an observation, we relax the filters 1 by 1 starting from the bottom until we have an observations. This ensures that data is shown after filter have been loaded, and it also tries to keep as much as possible what the user has chosen (= change the bottomost filters first).
fix #327
fix #328