Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard errors support 1 (column, grouped, tooltip, checkbox) #353

Closed
6 tasks done
ptbrowne opened this issue Feb 16, 2022 · 8 comments
Closed
6 tasks done

Standard errors support 1 (column, grouped, tooltip, checkbox) #353

ptbrowne opened this issue Feb 16, 2022 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@ptbrowne
Copy link
Collaborator

ptbrowne commented Feb 16, 2022

The RDF cube schema defines related dimensions concept. The first related dimension type is the standard error.

  • Add "related" field to each dimensions / measures with the information from meta/dimensionRelation
  • Draw error whiskers if the standard error related dimension is available
  • Support percentage unit
  • Simple column chart
  • Grouped column chart
  • Ability to activate / deactivate via checkbox (default would be checked)

EDIT: Add testing preview link : https://test.visualize.admin.ch/en/create/new?from=8sxAJrDh0tjd

@ptbrowne ptbrowne mentioned this issue Feb 16, 2022
1 task
@ptbrowne ptbrowne self-assigned this Feb 16, 2022
@AnninaWalker
Copy link
Contributor

The link above doesn't work. Where can I preview?

@AnninaWalker
Copy link
Contributor

The standard error itself looks good to me, but the filters in the right side panel are not loaded. Not sure if this has anything to do with each other or if this is another bug.
Screenshot 2022-02-17 at 17 53 00

@Rdataflow
Copy link
Contributor

@ptbrowne cc @AnninaWalker what about

  • stacked bar chart

@ptbrowne
Copy link
Collaborator Author

We have mockups for this, I added it to the list in the description.

@ptbrowne
Copy link
Collaborator Author

I am creating another issue for this @AnninaWalker, it's not the same thing, it's a perf issue when loading the filters.

#374

@ptbrowne ptbrowne changed the title Standard errors support Standard errors support 1 Feb 18, 2022
@ptbrowne
Copy link
Collaborator Author

@Rdataflow @sosiology I moved over the remaining tasks to #375 for clarity.

@ptbrowne ptbrowne changed the title Standard errors support 1 Standard errors support 1 (column, grouped, tooltip, checkbox) Feb 18, 2022
@ptbrowne
Copy link
Collaborator Author

Fixed in #352 #356 #366, stacked chart, line and scatterplot will done in a future PR.

@AnninaWalker
Copy link
Contributor

LGTM!

@ptbrowne ptbrowne added enhancement New feature or request and removed feature request labels Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants