Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error bars 1 #352

Merged
merged 9 commits into from
Feb 16, 2022
Merged

Error bars 1 #352

merged 9 commits into from
Feb 16, 2022

Conversation

ptbrowne
Copy link
Collaborator

@ptbrowne ptbrowne commented Feb 16, 2022

In this PR, standard errors support is added to visualize.

  • Display error whiskers automatically on simple column chart

Other PRs will follow to refine the functionality (tooltip support, activate / deactivate, support in horizontal chart).

Related meta issue : #353

The dataset where the standard error dimension is available is "LFI Data Cube [Version 1]: Waldfläche / Produktionsregion"

@ptbrowne ptbrowne temporarily deployed to visualize-ad-error-bars-allekv February 16, 2022 09:50 Inactive
@ptbrowne ptbrowne temporarily deployed to visualize-ad-error-bars-allekv February 16, 2022 09:54 Inactive
@ptbrowne ptbrowne temporarily deployed to visualize-ad-error-bars-allekv February 16, 2022 10:01 Inactive
Copy link
Collaborator

@bprusinowski bprusinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good work! I know this is just a first part of error bars, but there is one thing I would also consider adding – making the scales aware of whiskers, so they won't be able to go outside the SVG.

app/charts/column/columns-state.tsx Show resolved Hide resolved
@ptbrowne ptbrowne merged commit ad01209 into main Feb 16, 2022
@ptbrowne ptbrowne deleted the error-bars branch February 16, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants