Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve initial selection of filters #91

Closed
jstcki opened this issue May 27, 2021 · 4 comments
Closed

Improve initial selection of filters #91

jstcki opened this issue May 27, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@jstcki
Copy link
Contributor

jstcki commented May 27, 2021

When choosing a chart type, the intial filter selection is not checking if there are actually observations present for a particular set of filters. Users sometimes will see a "no data for current filter selection" message.

This should be improved by checking for existing filter sets. A simple approach would be to query one observation and pick its dimension values as intial filters. This way, the user would always at least see one observation.
@jstcki jstcki added the enhancement New feature or request label May 27, 2021
@ptbrowne
Copy link
Collaborator

Fixed in #343 :) We had the same idea for the approach :)

@AnninaWalker
Copy link
Contributor

👍

@sosiology
Copy link
Contributor

LGTM! Tested in Firefox and Chrome with various data sets

@MichelaBurzio
Copy link

Tested in Safari and Edge 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jstcki @ptbrowne @sosiology @AnninaWalker @MichelaBurzio