-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/chart config custom color palettes #1930
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @noahonyejese, it goes in the right direction, good work 👏 👨🎨
I added some comments, but I might also lack some context and missed some things – I know it's still a WIP, but thought it's better to raise them earlier than later 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @noahonyejese for tackling the feedback 🙇♂️
I think it would be good to make the deployment work, so the feature could be tested + add some unit tests 👍
I'd also check if "dimension" segment color type still works (you can use Forest fire danger
dataset from PROD that has colors attached to dimension values), see https://visualize.admin.ch/en/create/new?cube=https://environment.ld.admin.ch/foen/gefahren-waldbrand-warnung/1&dataSource=Prod 🔥
This PR:
How to test
@bprusinowski let me know if this is going in the right direction, note it's still heavily under construction