Hierarchical filters #233
Merged
Hierarchical filters #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
refactor/filter-components
to
feat/hierarchical-filters-main
November 30, 2021 09:21
…sharing common state
Prepare for using parent checkbox to activate / deactivate multiple filters
Seems like we do not need the distinction between SET and ADD check action
ptbrowne
force-pushed
the
feat/hierarchical-filters
branch
from
d1e1288 to
79ab43d
Compare
ptbrowne
force-pushed
the
feat/hierarchical-filters
branch
from
79ab43d to
7e75c75
Compare
Used in the dimension tree, can expand collapse, has rudimentary animation
Add helpers to infer hierarchy from dataset values Render filters as tree given a hierarchy
ptbrowne
force-pushed
the
feat/hierarchical-filters
branch
from
7e75c75 to
7dd70e9
Compare
ptbrowne
force-pushed
the
feat/hierarchical-filters
branch
from
fca9f2d to
9387a5a
Compare
bprusinowski
approved these changes
Jan 18, 2022
ptbrowne
force-pushed
the
feat/hierarchical-filters
branch
from
674e06f to
e1c7a03
Compare
ptbrowne
force-pushed
the
feat/hierarchical-filters
branch
from
e1c7a03 to
7bfb59a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DimensionValuesMultiFilter is now displayed as a tree
The hierarchy is for now hardcoded for the bathing site dataset
Various refactors were necessary on widgets like the selectbox to be able to cleanly insert this feature.
See the result here : https://visualize-ad-feat-hiera-6sn1sd.herokuapp.com/en/create/zU4PAOQ38gfL