-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search improvements #256
Search improvements #256
Conversation
@FabianCretton, @pdumas, @ortnever I'd be interested on your feedback concerning the search on this deployment. I think it's much better than before. I want to know if I include this in the release of Monday. Thanks ! You can test here: https://visualize-ad-search-lk1hpzdeez.herokuapp.com/fr/browse cc @sosiology |
Thanks for this improvment. |
Can you give me your search @ortnever ? The search should works in the description: Additionally, it searches in the themes, in the creator, and in the keywords (that are not displayed yet on visualize). |
It was "coli" but I tried again and it works. |
i did only a small test, but yes, looks much better, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Works much better than before 👌
Still using server side search, but improving the search by using lunr.
Fix #258