Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search improvements #256

Merged
merged 15 commits into from
Feb 28, 2022
Merged

Search improvements #256

merged 15 commits into from
Feb 28, 2022

Conversation

ptbrowne
Copy link
Collaborator

@ptbrowne ptbrowne commented Dec 8, 2021

Still using server side search, but improving the search by using lunr.

Fix #258

@jstcki jstcki temporarily deployed to visualize-ad-search-rfimjjlwpq December 8, 2021 15:08 Inactive
@ptbrowne ptbrowne temporarily deployed to visualize-ad-search-rfimjjlwpq December 8, 2021 16:05 Inactive
@ptbrowne ptbrowne temporarily deployed to visualize-ad-search-rfimjjlwpq December 9, 2021 09:04 Inactive
@ptbrowne ptbrowne temporarily deployed to visualize-ad-search-rfimjjlwpq December 9, 2021 12:20 Inactive
@ptbrowne ptbrowne temporarily deployed to visualize-ad-search-rfimjjlwpq December 9, 2021 16:01 Inactive
@ptbrowne ptbrowne changed the title Search improvements draft Search improvements Feb 25, 2022
@ptbrowne ptbrowne temporarily deployed to visualize-ad-search-lk1hpzdeez February 25, 2022 10:36 Inactive
@ptbrowne ptbrowne temporarily deployed to visualize-ad-search-lk1hpzdeez February 25, 2022 10:45 Inactive
@ptbrowne ptbrowne temporarily deployed to visualize-ad-search-lk1hpzdeez February 25, 2022 10:55 Inactive
@ptbrowne
Copy link
Collaborator Author

@FabianCretton, @pdumas, @ortnever I'd be interested on your feedback concerning the search on this deployment. I think it's much better than before. I want to know if I include this in the release of Monday. Thanks !

You can test here: https://visualize-ad-search-lk1hpzdeez.herokuapp.com/fr/browse

cc @sosiology

@ortnever
Copy link

Thanks for this improvment.
It works great but unfortunately only if the keyword is in the title. As the title is often very short, it requires very precise keywords. Would it be possible to do exactly the same thing by also looking for the word in the description?

@ptbrowne
Copy link
Collaborator Author

Can you give me your search @ortnever ? The search should works in the description:

image

Additionally, it searches in the themes, in the creator, and in the keywords (that are not displayed yet on visualize).

@ortnever
Copy link

It was "coli" but I tried again and it works.
It is very good.
To be deployed on Monday if you are sure there are no side effects elsewhere but there is no reason why the research should influence anything else.

@FabianCretton
Copy link

i did only a small test, but yes, looks much better, thanks!

Copy link
Collaborator

@bprusinowski bprusinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Works much better than before 👌

app/utils/search.ts Outdated Show resolved Hide resolved
app/utils/search.ts Outdated Show resolved Hide resolved
app/utils/search.ts Outdated Show resolved Hide resolved
@ptbrowne ptbrowne temporarily deployed to visualize-ad-search-lk1hpzdeez February 28, 2022 09:53 Inactive
@ptbrowne ptbrowne merged commit 8801866 into main Feb 28, 2022
@ptbrowne ptbrowne deleted the search branch February 28, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improvements to search Search full words Search datasets - Character String
5 participants