Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include Position for Ordinal Dimensions #262

Merged
merged 17 commits into from
Jan 31, 2022
Merged

Include Position for Ordinal Dimensions #262

merged 17 commits into from
Jan 31, 2022

Conversation

jstcki
Copy link
Contributor

@jstcki jstcki commented Dec 9, 2021 •
edited by ptbrowne
Loading

A less disruptive approach than #227

To Do

  • Implement query and resolver for position

@ptbrowne ptbrowne force-pushed the ordinal-dimension-simple branch from 3b55a7d to 3b15c99 Compare January 28, 2022 11:12
@ptbrowne ptbrowne requested a review from bprusinowski January 28, 2022 13:39
ptbrowne added 15 commits January 28, 2022 14:43
@ptbrowne
feat: Load positions for ordinal dimensions
808ce36
@ptbrowne
chore: Cleanup
a057816
@ptbrowne
feat: Sort ordinal dimension values by position in left panel select
2d70032
@ptbrowne
feat: Checkboxes are sorted by value order in the right panel
ebaee9e
@ptbrowne
refactor: Use simpler function for easier composition for ordinal sorter
bbe6f20
@ptbrowne
refactor: Use same renderer for chart preview/published
3c49afc
@ptbrowne
refactor: Lazy get of sorted segments depending on sort method
15d9cfd
@ptbrowne
refactor: Use generic type to filter out types that do not have colors
dcafc60
@ptbrowne
refactor: Use useMemo for segments sorting in bars state
5fafb9a
@ptbrowne
refactor: Use useMemo for segments sorting in lines state
58f568d
@ptbrowne
refactor: Use useMemo for segments sorting in areas state
c581b5b
@ptbrowne
feat: Order segments by position for ordinal dimensions in columns st…
1c140ea 
…acked
@ptbrowne
feat: Order segments by position for ordinal dimensions in columns chart
a397b46
@ptbrowne
feat: Order segments by position for ordinal dimensions in lines chart
794a28d
@ptbrowne
feat: Order segments by position for ordinal dimensions in area chart
d00ccd0
@ptbrowne ptbrowne force-pushed the ordinal-dimension-simple branch from 3b15c99 to d00ccd0 Compare January 28, 2022 16:28
@bprusinowski
Copy link
Collaborator

LGTM! 👍

@ptbrowne ptbrowne marked this pull request as ready for review January 31, 2022 09:43
@ptbrowne ptbrowne requested a review from bprusinowski January 31, 2022 09:43
@ptbrowne ptbrowne merged commit 67f8eec into main Jan 31, 2022
@ptbrowne ptbrowne deleted the ordinal-dimension-simple branch January 31, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bprusinowski bprusinowski Awaiting requested review from bprusinowski bprusinowski is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jstcki @bprusinowski @ptbrowne