-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cascading facets #271
Cascading facets #271
Conversation
73b9dd3
to
87a87d8
Compare
87a87d8
to
2471329
Compare
2471329
to
890bc3f
Compare
890bc3f
to
9776579
Compare
9776579
to
2814ac0
Compare
3e42746
to
62e3324
Compare
d9ac986
to
f598b78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌
Filter values are filtered given the filters above
bdd4805
to
6ed7a68
Compare
d8649aa
to
8db5138
Compare
@bprusinowski I rebased and pushed new commits, I think you finished your last review at |
Yes, I will review the changes tomorrow morning :) Thanks for letting me know! |
Apart from one comment about a drag n drop icon name, everything looks good! Edit: in fact, I noticed one thing on the preview deployment, not sure if it's related to changes in this PR. scrolling.bug.-.720p.mov |
Styling for making panel content take all the space should only be done for the configurator panel
0db4855
to
aac02a6
Compare
Thanks good catch, this was due to styling for the panel left being applied a bit too broadly, I moved the styles only to the PanelLeft in the chart configurator. Those styles are there for the content of the panel left to take all the space available. |
In this PR, the left filters are reworked cascading facets.
To be decided...)In this PR we rely heavily on the fact that in javascript, objects should retain the order of the keys in insertion order. It should work for now but I think that filters should be transformed into an array for clarity.