Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Hide area and symbol layers options if no matching geo dimensions are found #301

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

bprusinowski
Copy link
Collaborator

No description provided.

@bprusinowski bprusinowski requested a review from ptbrowne January 27, 2022 15:54
@ptbrowne ptbrowne temporarily deployed to visualize-ad-feat-hide--lt5div January 27, 2022 15:55 Inactive
@bprusinowski bprusinowski merged commit 606b12b into main Feb 1, 2022
Copy link
Collaborator

@ptbrowne ptbrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be a missing translation in German (not sure it is from this PR though) and I am wondering about the exclamation point in the note about no geographical dimensions. Otherwise LGTM.

app/locales/de/messages.po Show resolved Hide resolved
app/locales/de/messages.po Show resolved Hide resolved
app/locales/de/messages.po Show resolved Hide resolved
@bprusinowski bprusinowski deleted the feat/hide-area-layer-options-if-no-geodimension branch February 1, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants