Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polishing the maps #302

Merged
merged 22 commits into from
Feb 1, 2022
Merged

Polishing the maps #302

merged 22 commits into from
Feb 1, 2022

Conversation

bprusinowski
Copy link
Collaborator

@bprusinowski bprusinowski commented Feb 1, 2022

  • changed base layer active tab switch to OnOffControlTabField
  • updated translations for maps
  • added urql devtools for non-prod environments
  • fixed duplicated fetching of observations due to mismatch in input variables across different files for maps
  • added separate queries to fetch geoCoordinates and geoShapes, so they aren't fetched with each filter change
  • made the dimension values fetching only applicable for actual filter reorder so results are cached

@ptbrowne ptbrowne temporarily deployed to visualize-ad-feat-maps--nplrls February 1, 2022 08:15 Inactive
@ptbrowne ptbrowne temporarily deployed to visualize-ad-feat-maps--nplrls February 1, 2022 08:21 Inactive
@ptbrowne ptbrowne temporarily deployed to visualize-ad-feat-maps--nplrls February 1, 2022 08:22 Inactive
@bprusinowski bprusinowski marked this pull request as ready for review February 1, 2022 09:03
@ptbrowne ptbrowne temporarily deployed to visualize-ad-feat-maps--nplrls February 1, 2022 09:03 Inactive
@bprusinowski bprusinowski requested a review from ptbrowne February 1, 2022 09:04
@ptbrowne ptbrowne had a problem deploying to visualize-ad-feat-maps--nplrls February 1, 2022 10:03 Failure
@ptbrowne ptbrowne temporarily deployed to visualize-ad-feat-maps--nplrls February 1, 2022 11:18 Inactive
@ptbrowne ptbrowne temporarily deployed to visualize-ad-feat-maps--nplrls February 1, 2022 11:19 Inactive
@ptbrowne ptbrowne temporarily deployed to visualize-ad-feat-maps--nplrls February 1, 2022 12:01 Inactive
@ptbrowne ptbrowne temporarily deployed to visualize-ad-feat-maps--nplrls February 1, 2022 12:18 Inactive
@ptbrowne ptbrowne temporarily deployed to visualize-ad-feat-maps--nplrls February 1, 2022 13:20 Inactive
@ptbrowne ptbrowne temporarily deployed to visualize-ad-feat-maps--nplrls February 1, 2022 14:11 Inactive
@ptbrowne ptbrowne temporarily deployed to visualize-ad-feat-maps--nplrls February 1, 2022 14:35 Inactive
@ptbrowne ptbrowne temporarily deployed to visualize-ad-feat-maps--nplrls February 1, 2022 15:34 Inactive
app/locales/fr/messages.po Outdated Show resolved Hide resolved
app/locales/it/messages.po Outdated Show resolved Hide resolved
Copy link
Collaborator

@ptbrowne ptbrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there is only the comment about the french translation for Select a color. Good job on the perf improvements !

@ptbrowne ptbrowne temporarily deployed to visualize-ad-feat-maps--nplrls February 1, 2022 16:26 Inactive
@bprusinowski bprusinowski merged commit ba4b7c5 into main Feb 1, 2022
@bprusinowski bprusinowski deleted the feat/maps-polishing branch February 1, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants