Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Redirect to latest cube iri when going to on browse/dataset/<unversionedIri> #303

Merged
merged 2 commits into from
Feb 1, 2022

Conversation

ptbrowne
Copy link
Collaborator

@ptbrowne ptbrowne commented Feb 1, 2022

Fixes #288

When we land on /en/browse/dataset/, we fetch the latest published cube to get the latest unversioned iri and redirect server side to /en/browse/dataset/.
To detect unversionedIri, a heuristic is used, it should end with /<number>/.

@ptbrowne ptbrowne temporarily deployed to visualize-ad-fix-browse-glfhwf February 1, 2022 14:41 Inactive
@ptbrowne ptbrowne changed the title feat: Redirect to latest cube iri if coming in browse/dataset with un… feat: Redirect to latest cube iri when going to on browse/dataset/<unversionedIri> Feb 1, 2022
@ptbrowne ptbrowne force-pushed the fix/browse-unversioned-iri branch from 7d8160e to dbd71ef Compare February 1, 2022 14:57
@ptbrowne ptbrowne temporarily deployed to visualize-ad-fix-browse-glfhwf February 1, 2022 14:57 Inactive
@ptbrowne ptbrowne requested a review from bprusinowski February 1, 2022 15:34
@ptbrowne ptbrowne enabled auto-merge February 1, 2022 15:34
@ptbrowne ptbrowne merged commit 212665a into main Feb 1, 2022
Copy link
Collaborator

@bprusinowski bprusinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ptbrowne ptbrowne deleted the fix/browse-unversioned-iri branch February 1, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link to unversioned entry of Cube in Visualize does not work anymore.
2 participants