Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling of error and loading states #304

Merged
merged 3 commits into from
Feb 1, 2022
Merged

Handling of error and loading states #304

merged 3 commits into from
Feb 1, 2022

Conversation

ptbrowne
Copy link
Collaborator

@ptbrowne ptbrowne commented Feb 1, 2022 •
edited
Loading

  • Do not show loader in browsing metadata panel
  • Show error message if dataset cannot be loaded

@ptbrowne ptbrowne temporarily deployed to visualize-ad-feat-loadi-okhafj February 1, 2022 15:54 Inactive
@ptbrowne ptbrowne force-pushed the feat/loading-and-error branch from f897ea2 to fcbda35 Compare February 1, 2022 15:55
@ptbrowne ptbrowne temporarily deployed to visualize-ad-feat-loadi-okhafj February 1, 2022 15:55 Inactive
@ptbrowne ptbrowne requested a review from bprusinowski February 1, 2022 15:55
@ptbrowne ptbrowne temporarily deployed to visualize-ad-feat-loadi-okhafj February 1, 2022 15:58 Inactive
@ptbrowne ptbrowne enabled auto-merge February 1, 2022 16:07
bprusinowski
bprusinowski approved these changes Feb 1, 2022
View reviewed changes
Copy link
Collaborator

@bprusinowski bprusinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved :)

@ptbrowne ptbrowne merged commit 2cedc34 into main Feb 1, 2022
@ptbrowne ptbrowne deleted the feat/loading-and-error branch February 1, 2022 16:09
@ptbrowne ptbrowne mentioned this pull request Apr 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bprusinowski bprusinowski bprusinowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ptbrowne @bprusinowski