-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Discrete color scales with < 3 values + display lakes and rivers #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bprusinowski
commented
Feb 1, 2022
•
edited
Loading
edited
- Fixes discrete color scales with < 3 observations for maps
- Adds new MVTLayer which displays lakes and rivers
- Fixes shape fill color when value === 0
bprusinowski
force-pushed
the
fix/discrete-color-scale-for-maps
branch
from
February 3, 2022 12:44
11e8d93
to
ccac1d8
Compare
Discrete color scales for maps still need a proper fix, but at least they will now work when number of observations is lower than 3. |
…into fix/discrete-color-scale-for-maps
ptbrowne
changed the title
fix: Discrete color scales with < 3 values
fix: Discrete color scales with < 3 values + display lakes and rivers
Feb 8, 2022
ptbrowne
approved these changes
Feb 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.