Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Discrete color scales with < 3 values + display lakes and rivers #309

Merged
merged 10 commits into from
Feb 8, 2022

Conversation

bprusinowski
Copy link
Collaborator

@bprusinowski bprusinowski commented Feb 1, 2022

  • Fixes discrete color scales with < 3 observations for maps
  • Adds new MVTLayer which displays lakes and rivers
  • Fixes shape fill color when value === 0

@bprusinowski bprusinowski requested a review from ptbrowne February 1, 2022 17:18
@ptbrowne ptbrowne temporarily deployed to visualize-ad-fix-discre-um5kxs February 1, 2022 17:18 Inactive
@bprusinowski bprusinowski disabled auto-merge February 2, 2022 08:17
@bprusinowski bprusinowski marked this pull request as draft February 2, 2022 08:17
@ptbrowne ptbrowne had a problem deploying to visualize-ad-fix-discre-um5kxs February 2, 2022 12:21 Failure
@bprusinowski bprusinowski force-pushed the fix/discrete-color-scale-for-maps branch from 11e8d93 to ccac1d8 Compare February 3, 2022 12:44
@ptbrowne ptbrowne had a problem deploying to visualize-ad-fix-discre-um5kxs February 3, 2022 12:44 Failure
@ptbrowne ptbrowne temporarily deployed to visualize-ad-fix-discre-um5kxs February 3, 2022 12:47 Inactive
@ptbrowne ptbrowne temporarily deployed to visualize-ad-fix-discre-um5kxs February 3, 2022 16:54 Inactive
@bprusinowski bprusinowski marked this pull request as ready for review February 3, 2022 16:54
@bprusinowski
Copy link
Collaborator Author

Discrete color scales for maps still need a proper fix, but at least they will now work when number of observations is lower than 3.

@ptbrowne ptbrowne temporarily deployed to visualize-ad-fix-discre-um5kxs February 3, 2022 16:57 Inactive
@ptbrowne ptbrowne changed the title fix: Discrete color scales with < 3 values fix: Discrete color scales with < 3 values + display lakes and rivers Feb 8, 2022
@ptbrowne ptbrowne temporarily deployed to visualize-ad-fix-discre-um5kxs February 8, 2022 15:45 Inactive
Copy link
Collaborator

@ptbrowne ptbrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 🎉

@ptbrowne ptbrowne merged commit 1fc33ec into main Feb 8, 2022
@ptbrowne ptbrowne deleted the fix/discrete-color-scale-for-maps branch February 8, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants