Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search and drafts count #396

Merged
merged 3 commits into from
Feb 21, 2022
Merged

Fix search and drafts count #396

merged 3 commits into from
Feb 21, 2022

Conversation

ptbrowne
Copy link
Collaborator

fix #391

  • fix: Consider include drafts checkbox when computing search counts
  • feat: Keep search and includeDrafts when clicking inside nav panel

@ptbrowne ptbrowne temporarily deployed to visualize-ad-fix-search-ib1vdx February 21, 2022 15:38 Inactive
@ptbrowne ptbrowne changed the title Fix search drafts Fix search and drafts count Feb 21, 2022
Otherwise when checking drafts checkbox, counts were not OK
When clicking in nav panel links, search and includeDrafts state were
lost
@ptbrowne ptbrowne force-pushed the fix/search-draft-nav branch from 77aa964 to 36c1fe4 Compare February 21, 2022 15:43
@ptbrowne ptbrowne temporarily deployed to visualize-ad-fix-search-fa8ovq February 21, 2022 15:43 Inactive
Copy link
Collaborator

@bprusinowski bprusinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@ptbrowne ptbrowne merged commit dbf7b3b into main Feb 21, 2022
@ptbrowne ptbrowne deleted the fix/search-draft-nav branch February 21, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search options combinations seems buggy
2 participants