Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map improvements #397

Merged
merged 4 commits into from
Feb 21, 2022
Merged

Map improvements #397

merged 4 commits into from
Feb 21, 2022

Conversation

bprusinowski
Copy link
Collaborator

@bprusinowski bprusinowski commented Feb 21, 2022

  • add attribution to the map
  • disable right panel filter on the map is layer is not active

@ptbrowne ptbrowne temporarily deployed to visualize-ad-feat-map-i-nodoo7 February 21, 2022 15:51 Inactive
gridGap: 1,
alignItems: "flex-end",
}}
>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I would have used Stack for this.

<Stack direction='row' spacing={1}
</Stack>

I think it is a bit simpler and you do not need the ICON_SIZE.

Copy link
Collaborator

@ptbrowne ptbrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit on the implementation of the attribution box.

LGTM 👍 Thanks

@ptbrowne ptbrowne requested a deployment to visualize-ad-feat-map-i-nodoo7 February 21, 2022 16:18 Abandoned
@ptbrowne ptbrowne temporarily deployed to visualize-ad-feat-map-i-nodoo7 February 21, 2022 16:23 Inactive
@bprusinowski bprusinowski merged commit 45f269a into main Feb 21, 2022
@bprusinowski bprusinowski deleted the feat/map-improvements branch February 21, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants