Add Generic Typing for decorate_view
to resolve Pyright Issues
#1126
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For projects using Django Ninja that utilize Pyright, the typing for
decorate_view
leads to areportUntypedFunctionDecorator
error.Let's take this example from the documentation:
By having
decorate_view
utilize generics, we can can avoid this. I also went about generally cleaning up the callable types,Callable[..., Any]
is more descriptive thanCallable
. In Pyright the former would be preferred to avoid unknowns, asCallable == Callable[..., Unknown]
instead of beingAny
. There have been times where I've imported private functions from ninja internals, while not often, it would be nice to avoid unknowns in these cases.