Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db: Rename hash functions #393

Merged
merged 2 commits into from
Feb 18, 2019
Merged

db: Rename hash functions #393

merged 2 commits into from
Feb 18, 2019

Conversation

d3m3vilurr
Copy link
Contributor

all applied camelCase
it also fixed typo ksceSblDmac5AEsCbcDec

all applied camelCase
it also fixed typo `ksceSblDmac5AEsCbcDec`
@CelesteBlue-dev
Copy link
Contributor

CelesteBlue-dev commented Feb 14, 2019

nice but if you rename then better to use proper names. look wiki: WithKeygen -> NP
https://wiki.henkaku.xyz/vita/SceSblSsMgr#sceSblDmac5AesEcbEncNPForDriver

@d3m3vilurr
Copy link
Contributor Author

well...WithKeygen would be okay, imo that was called with sceSblDmac5EncDecKeyGen data by user side
but actually i don't care both, just I need definition of NP

@CelesteBlue-dev
Copy link
Contributor

NP = NoPortability. That's because these NP functions dont use enc_dec_with_portability_sm.self (a f00d module) that stores the keys.

@d3m3vilurr
Copy link
Contributor Author

ok. it reasonable name. i'll change it.

@d3m3vilurr
Copy link
Contributor Author

d3m3vilurr commented Feb 14, 2019

hm we already have WithPortability postfix

  1. remove them
  2. NP replace to WithoutPortability postfix.

what do you prefer?

@CelesteBlue-dev
Copy link
Contributor

@devnoname120 and me made a tool to get names from the wiki and then insert into db.yml
I think it could be easier to use this tool.
In all cases, take the names from wiki then fix typos.

@d3m3vilurr
Copy link
Contributor Author

d3m3vilurr commented Feb 14, 2019

as you know we(vitasdk team) don't care original sce names.
we just focus that names have readability, right meaning and backward compatibility.
also this patchset is one of polishing definition after importing.

@d3m3vilurr
Copy link
Contributor Author

okay no more conversation here.
only remain issues are

  1. WithPortability part
  2. NoPortability(WithKeygen) part.

I agree that WithKeygen is meanless name, but NP also too short/meanless postfix.
just it's better than WithKeygen.

my options are

  1. remove WithPortability postifx
  2. we use WithoutProtability instead NP

I just merge current code and I'll make an another issue for that.

@d3m3vilurr d3m3vilurr merged commit bf7dbcb into vitasdk:master Feb 18, 2019
@d3m3vilurr d3m3vilurr deleted the rename-aes branch February 18, 2019 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants