Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support new React Compiler target option #374

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Conversation

poteto
Copy link
Contributor

@poteto poteto commented Oct 10, 2024

React Compiler was updated to accept a target option and runtimeModule was removed. vite-plugin-react will still detect runtimeModule for backwards compatibility.

Description

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@poteto poteto changed the title Support new React Compiler target option feat: Support new React Compiler target option Oct 10, 2024
poteto added a commit to facebook/react that referenced this pull request Oct 10, 2024
`yarn dev` doesn't work quite correctly because of an outdated assumption in vite-plugin-react, I have a [PR open](vitejs/vite-plugin-react#374) to address.

However `yarn build` and `yarn preview` does work as expected.
poteto added a commit to facebook/react that referenced this pull request Oct 10, 2024
`yarn dev` doesn't work quite correctly because of an outdated assumption in vite-plugin-react, I have a [PR open](vitejs/vite-plugin-react#374) to address.

However `yarn build` and `yarn preview` does work as expected.
poteto added a commit to facebook/react that referenced this pull request Oct 10, 2024
`yarn dev` doesn't work quite correctly because of an outdated assumption in vite-plugin-react, I have a [PR open](vitejs/vite-plugin-react#374) to address.

However `yarn build` and `yarn preview` does work as expected.
poteto added a commit to facebook/react that referenced this pull request Oct 10, 2024
`yarn dev` doesn't work quite correctly because of an outdated assumption in vite-plugin-react, I have a [PR open](vitejs/vite-plugin-react#374) to address.

However `yarn build` and `yarn preview` does work as expected.
React Compiler was updated to accept a [`target` option](facebook/react#31143) and [`runtimeModule` was removed](facebook/react#31145). vite-plugin-react will still detect `runtimeModule` for backwards compatibility.
poteto added a commit to facebook/react that referenced this pull request Oct 10, 2024
`yarn dev` doesn't work quite correctly because of an outdated assumption in vite-plugin-react, I have a [PR open](vitejs/vite-plugin-react#374) to address.

However `yarn build` and `yarn preview` does work as expected.
poteto added a commit to facebook/react that referenced this pull request Oct 10, 2024
`yarn dev` doesn't work quite correctly because of an outdated
assumption in vite-plugin-react, I have a [PR
open](vitejs/vite-plugin-react#374) to address.

However `yarn build` and `yarn preview` does work as expected.
---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed
with [ReviewStack](https://reviewstack.dev/facebook/react/pull/31166).
* #31167
* __->__ #31166
* #31165
@ArnaudBarre ArnaudBarre changed the title feat: Support new React Compiler target option feat: support new React Compiler target option Oct 12, 2024
Copy link
Collaborator

@hi-ogawa hi-ogawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ArnaudBarre ArnaudBarre merged commit 7a7e339 into vitejs:main Oct 16, 2024
7 checks passed
@poteto poteto deleted the rcr branch October 16, 2024 18:26
@poteto
Copy link
Contributor Author

poteto commented Oct 18, 2024

@ArnaudBarre would you mind cutting a new release? Thanks!

@ArnaudBarre
Copy link
Member

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants