Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make it work when a default lang is specified #65

Closed
wants to merge 1 commit into from

Conversation

sapphi-red
Copy link
Member

Description

<template lang="html">
  <div>foo</div>
</script>

and

<script setup lang="js">
const foo = 'foo'
</script>

didn't work.
This PR fixes these.

requires vuejs/core#7388
fixes #17

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p3-minor-bug 🔨 An edge case that only affects very specific usage (priority) label Dec 21, 2022
@sapphi-red sapphi-red changed the title fix: make it work when a default lang was specified fix: make it work when a default lang is specified Dec 21, 2022
@sapphi-red sapphi-red marked this pull request as ready for review April 22, 2023 07:33
Copy link
Contributor

@dargmuesli dargmuesli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sapphi-red the required fix vuejs/core#7388 is merged and should be included in the most recent Vue versions. What do you think about the status of this PR?

@sapphi-red
Copy link
Member Author

This PR is a bit low priority for me. Feel free to rebase this PR. I'd be happy to review it.

@dargmuesli
Copy link
Contributor

Rebased on #223 :)

@sapphi-red sapphi-red closed this Aug 9, 2023
@sapphi-red sapphi-red deleted the fix/default-langs-specified branch August 9, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug 🔨 An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: template uses lang html for template, however it is not installed
2 participants