fix(ssr): no external symlink package (#9296)

packages/vite/src/node/plugins/resolve.ts

@@ -656,6 +656,10 @@ export function tryNodeResolve(
     if (!externalize) {
       return resolved
     }
+    // dont external symlink packages
+    if (!resolved.id.includes('node_modules')) {
+      return
+    }
     const resolvedExt = path.extname(resolved.id)
     let resolvedId = id
     if (isDeepImport) {

playground/ssr-deps/__tests__/ssr-deps.spec.ts

@@ -98,3 +98,8 @@ test('msg from external using external entry', async () => {
     'Hello World!'
   )
 })
+
+test('msg from linked no external', async () => {
+  await page.goto(url)
+  expect(await page.textContent('.linked-no-external')).toMatch('Hello World!')
+})

playground/ssr-deps/linked-no-external/index.js

@@ -0,0 +1,5 @@
+export const hello = function () {
+  // make sure linked package is not externalized so Vite features like
+  // import.meta.env works (or handling TS files)
+  return import.meta.env.DEV && 'Hello World!'
+}

playground/ssr-deps/linked-no-external/package.json

@@ -0,0 +1,6 @@
+{
+  "name": "linked-no-external",
+  "private": true,
+  "type": "module",
+  "version": "0.0.0"
+}

playground/ssr-deps/package.json

@@ -26,7 +26,8 @@
     "optimized-with-nested-external": "file:./optimized-with-nested-external",
     "optimized-cjs-with-nested-external": "file:./optimized-with-nested-external",
     "external-using-external-entry": "file:./external-using-external-entry",
-    "external-entry": "file:./external-entry"
+    "external-entry": "file:./external-entry",
+    "linked-no-external": "link:./linked-no-external"
   },
   "devDependencies": {
     "cross-env": "^7.0.3",

playground/ssr-deps/src/app.js

@@ -11,6 +11,7 @@ import onlyObjectAssignedExports from 'only-object-assigned-exports'
 import requireAbsolute from 'require-absolute'
 import noExternalCjs from 'no-external-cjs'
 import importBuiltinCjs from 'import-builtin-cjs'
+import { hello as linkedNoExternal } from 'linked-no-external'
 
 // This import will set a 'Hello World!" message in the nested-external non-entry dependency
 import 'non-optimized-with-nested-external'
@@ -75,5 +76,8 @@ export async function render(url, rootDir) {
   const externalUsingExternalEntryMessage = externalUsingExternalEntry.hello()
   html += `\n<p class="external-using-external-entry">message from external-using-external-entry: ${externalUsingExternalEntryMessage}</p>`
 
+  const linkedNoExternalMessage = linkedNoExternal()
+  html += `\n<p class="linked-no-external">message from linked-no-external: ${linkedNoExternalMessage}</p>`
+
   return html + '\n'
 }