Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(plugin-legacy): syntax error in variable detectModernBrowserCode #15095

Merged
merged 2 commits into from
Nov 22, 2023
Merged

fix(plugin-legacy): syntax error in variable detectModernBrowserCode #15095

merged 2 commits into from
Nov 22, 2023

Conversation

jiadesen
Copy link
Contributor

Description

fixes #15094

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

sapphi-red
sapphi-red approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 💚

@sapphi-red sapphi-red added plugin: legacy p5-urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority) labels Nov 22, 2023
@sapphi-red sapphi-red mentioned this pull request Nov 22, 2023
Merged
9 tasks
@patak-dev patak-dev merged commit 1c605ff into vitejs:main Nov 22, 2023
10 checks passed
@jiadesen jiadesen deleted the fix_detectModernBrowserCode_syntax_err branch November 22, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
p5-urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority) plugin: legacy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

plugin-legacy: syntax error in variable detectModernBrowserCode
3 participants
@jiadesen @patak-dev @sapphi-red