Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(legacy): add a test to checks all inline snippets are valid JS #15098

Merged
merged 2 commits into from
Nov 22, 2023
Merged

test(legacy): add a test to checks all inline snippets are valid JS #15098

merged 2 commits into from
Nov 22, 2023

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Nov 22, 2023 •
edited
Loading

Description

A test case for #15095. The tests will fail without #15095.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added plugin: legacy p1-chore Doesn't change code behavior (priority) test labels Nov 22, 2023
@sapphi-red sapphi-red changed the title test(legacy): add a test to assert all inline snippets are valid JS test(legacy): add a test to checks all inline snippets are valid JS Nov 22, 2023
@patak-dev patak-dev enabled auto-merge (squash) November 22, 2023 08:34
@patak-dev patak-dev merged commit 1b9ca66 into vitejs:main Nov 22, 2023
10 checks passed
@sapphi-red sapphi-red deleted the test/legacy-syntax-check branch November 22, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
p1-chore Doesn't change code behavior (priority) plugin: legacy test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sapphi-red @patak-dev