Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Providing additional babel plugins for plugin-react-refresh #3276

Closed
kjeske opened this issue May 5, 2021 · 5 comments · Fixed by #3588
Closed

Providing additional babel plugins for plugin-react-refresh #3276

kjeske opened this issue May 5, 2021 · 5 comments · Fixed by #3588
Labels
enhancement New feature or request p2-nice-to-have Not breaking anything but nice to have (priority)

Comments

@kjeske
Copy link

kjeske commented May 5, 2021

Emotion is a quite popular library for writing css styles with JavaScript. To use all the Emotion's development features, we need to use babel plugin called @emotion/babel-plugin. Before this PR it was possible to do it in the .babelrc file, but now that option is disabled.

As a developer using Vite I want to specify additional babel plugins used by plugin-react-refresh so that I can use all the features of Emotion library.

Suggested solution

Support passing additional babel plugins in a similar way as passing babel parser plugins (via options).

@kjeske
Copy link
Author

kjeske commented May 26, 2021

What do you think @nihalgonsalves @antfu, when it can be included in the release? This issue is the only thing that blocks our team from moving from snowpack to vite.

aleclarson pushed a commit to aleclarson/vite that referenced this issue May 29, 2021
@so11y
Copy link

so11y commented Jun 10, 2021

me too

@fengxinming
Copy link

fengxinming commented Sep 6, 2021

I have proposed a provisional plugin to work around this problem vite-plugin-react-refresh

@Shinigami92 Shinigami92 linked a pull request Sep 6, 2021 that will close this issue
13 tasks
@Shinigami92
Copy link
Member

@fengxinming
/cc @aleclarson

Seems the working on #3588 stands still 😕
Would you like to take it over and improve the react + vite experience for everyone?

@kjeske
Copy link
Author

kjeske commented Sep 23, 2021

Thank you all for awesome work and releasing plugin-react :)

@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2021
aleclarson pushed a commit to aleclarson/vite that referenced this issue Nov 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
5 participants