fix: prevent cache on optional package resolve #10812
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When resolving optional packages for Vite, like
sass
, use theresolve
package to resolve first to avoid nodejs caching the result (even if the module is not found).This allows users to install
sass
while the Vite server is still running, and it'll pick up the changes without restarting.Additional context
This is tricky to make a test for, but I've confirmed that it's working in the
playground
projects manually.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).