-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ssr): load sourcemaps alongside modules (fix: #3288) #11576
Conversation
It may be worth noting that this also allows me to use breakpoints in VSCode without any |
Video of me setting a breakpoint in a TS file in an Astro project with my changes and saving the file (to cause the module to be reloaded) Code_NCoKzatZOR.mp4 |
Just tested it with SvelteKit and it works great (EDIT: for me ;D)🎉 |
@manucorporat would you review this one in the context of Qwik? |
Don't know if it helps. In my test with Qwik debugging worked perfectly fine🤩 but I'm not an Qwik expert. |
@patak-dev is there anything blocking this pr, testing? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
The behavior looks good to me.
Co-authored-by: 翠 / green <green@sapphi.red>
@jere2101 what was the |
I tested it without a |
@sapphi-red I think I've addressed your concerns now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
…#3288) (vitejs#11576)" This reverts commit dc05e97.
Description
Fixes #3288
This PR adds runtime sourcemaps to SSR modules inline.
This isn't a very large change as vite's request transformer provides source maps. The only modification that needed to be made to the source maps was prepending
';;;'
to the mappings, as the first three lines of every module will look like this:Before Changes
After Changes
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).