Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): insert styles in the same position #11763

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

sapphi-red
Copy link
Member

Description

When a style was injected by JS, the order was inconsistent between dev and build.

While this works for the current style-injection approach, this is not feasible by the adoptedStyleSheets approach (currently disabled due to low perf) because adoptedStyleSheets are ordered after all the other style sheets.
I didn't touch the adoptedStyleSheets approach but maybe we can simply remove this.

fixes #11760

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added feat: css p3-minor-bug An edge case that only affects very specific usage (priority) inconsistency Inconsistency between dev & build labels Jan 20, 2023
@patak-dev patak-dev merged commit d2f1381 into vitejs:main Jan 25, 2023
@sapphi-red sapphi-red deleted the fix/css-order-bulk branch January 26, 2023 10:29
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: css inconsistency Inconsistency between dev & build p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite change the style order in production that cause the overwrite issue
2 participants