Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(define): remove inconsistent comment with import.meta.env replacement in lib mode #12152

Merged
merged 1 commit into from
Feb 22, 2023
Merged

chore(define): remove inconsistent comment with import.meta.env replacement in lib mode #12152

merged 1 commit into from
Feb 22, 2023

Conversation

smeng9
Copy link
Contributor

@smeng9 smeng9 commented Feb 22, 2023

Description

As a follow up of #8090, remove the irrelevant comment.

Make it clear that the comments in the code matches the behavior of the code.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy changed the title fix(comments): remove inconsistent comment with import.meta.env replacement in lib mode chore(define): remove inconsistent comment with import.meta.env replacement in lib mode Feb 22, 2023
@bluwy bluwy merged commit 2556f88 into vitejs:main Feb 22, 2023
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants