Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update @typescript-eslint/* dependencies to v6.0.0 #13817

Merged
merged 1 commit into from
Jul 15, 2023
Merged

chore(deps): update @typescript-eslint/* dependencies to v6.0.0 #13817

merged 1 commit into from
Jul 15, 2023

Conversation

xaviermawet
Copy link
Contributor

Description

Updated typescript-eslint to version 6.0.0 and resolved breaking changes using the official migration guide.

Additional context

Nothing.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Jul 13, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

bluwy
bluwy previously approved these changes Jul 13, 2023
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for making the changes without changing the source code, that makes it easier to review.

@bluwy bluwy added the dependencies Pull requests that update a dependency file label Jul 13, 2023
@bluwy bluwy requested a review from ArnaudBarre July 13, 2023 03:58
@ArnaudBarre
Copy link
Member

Thanks for the update. This config was already a mess, but I'm ok with these changes at the root. I will maybe update some rules later on.
For the React template, we decided to update the configuration and go back to a minimal stater. I will update the version in #13749 with other changes

@xaviermawet
Copy link
Contributor Author

xaviermawet commented Jul 13, 2023

Hi @bluwy, @ArnaudBarre,

Yes, the purpose of this PR was to upgrade to new configuration names and have the exact same ESLint configuration as before, without updating the code.

I had two options:

  1. not extend stylistic and manually add the rules that were in recommended v5 but no longer in recommended v6
  2. extend stylistic and disable the additional rules of stylistic v6 which were not in recommended v5 and conflicted with the current code.

I logically opted for the second solution which went in the direction of an additional quality of code.
The idea being to gradually remove these new deactivated rules (therefore activate them) in dedicated PRs.

@ArnaudBarre, do you want me to remove the changes from the React template to prevent conflicts with
#13749 where @typescript-eslint/* dependencies will be upgraded ?

Regards,

@ArnaudBarre
Copy link
Member

Yeah I agree this is the best choice for this PR and going in the good direction.

Yeah I would prefer not having a state where the main branch has again another set of rules in case we push a fix of create-vite before I merge #13749

Updated ESLint configuration to match previous configuration
@xaviermawet
Copy link
Contributor Author

I've just rebased my PR branch on top of main and reverted the commit that updated the React template to avoid conflicts with #13749.

Regards,

@xaviermawet xaviermawet changed the title chore(deps): update dependency @typescript-eslint/* to v6.0.0 chore(deps): update @typescript-eslint/* dependencies to v6.0.0 Jul 13, 2023
@ArnaudBarre
Copy link
Member

Thanks for the update, LGTM

@patak-dev patak-dev merged commit 45c6f3b into vitejs:main Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants