-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update @typescript-eslint/*
dependencies to v6.0.0
#13817
chore(deps): update @typescript-eslint/*
dependencies to v6.0.0
#13817
Conversation
Run & review this pull request in StackBlitz Codeflow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for making the changes without changing the source code, that makes it easier to review.
Thanks for the update. This config was already a mess, but I'm ok with these changes at the root. I will maybe update some rules later on. |
Hi @bluwy, @ArnaudBarre, Yes, the purpose of this PR was to upgrade to new configuration names and have the exact same ESLint configuration as before, without updating the code. I had two options:
I logically opted for the second solution which went in the direction of an additional quality of code. @ArnaudBarre, do you want me to remove the changes from the React template to prevent conflicts with Regards, |
Yeah I agree this is the best choice for this PR and going in the good direction. Yeah I would prefer not having a state where the main branch has again another set of rules in case we push a fix of create-vite before I merge #13749 |
Updated ESLint configuration to match previous configuration
I've just rebased my PR branch on top of Regards, |
@typescript-eslint/*
dependencies to v6.0.0
Thanks for the update, LGTM |
Description
Updated typescript-eslint to version 6.0.0 and resolved breaking changes using the official migration guide.
Additional context
Nothing.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).