Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency eslint-plugin-regexp to v2 #14730

Merged
merged 2 commits into from
Oct 26, 2023
Merged

chore(deps): update dependency eslint-plugin-regexp to v2 #14730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
edd26d8
chore(deps): update dependency eslint-plugin-regexp to v2
renovate[bot] Oct 23, 2023
1231ec0
chore: fix
bluwy Oct 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .eslintrc.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,8 @@ module.exports = defineConfig({
],

'regexp/no-contradiction-with-assertion': 'error',
// in some cases using explicit letter-casing is more performant than the `i` flag
'regexp/use-ignore-case': 'off',
Comment on lines +111 to +112
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked https://stackoverflow.com/questions/32010/is-regex-case-insensitivity-slower and I think we should ignore this rule for now. It's suggesting our [a-zA-Z] regexes to use the i flag.

},
overrides: [
{
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
"eslint-define-config": "^1.24.1",
"eslint-plugin-import": "^2.28.1",
"eslint-plugin-n": "^16.2.0",
"eslint-plugin-regexp": "^1.15.0",
"eslint-plugin-regexp": "^2.1.1",
"execa": "^8.0.1",
"fs-extra": "^11.1.1",
"lint-staged": "^15.0.1",
Expand Down
3 changes: 2 additions & 1 deletion packages/plugin-legacy/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,8 @@ function viteLegacyPlugin(options: Options = {}): Plugin[] {
fileName = fileName.replace(/[.-]?\[hash\]/, '-legacy$&')
} else {
// entry.js -> entry-legacy.js
fileName = fileName.replace(/(.+)\.(.+)/, '$1-legacy.$2')
// entry.min.js -> entry-legacy.min.js
fileName = fileName.replace(/(.+?)\.(.+)/, '$1-legacy.$2')
Comment on lines -347 to +348
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a mini breaking change as before entry.min.js would be entry.min-legacy.js, but luckily we were also fixing this for plugin-legacy's next major: #11599

}

return fileName
Expand Down
85 changes: 35 additions & 50 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.