Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: code frame was not generated for postcss errors #14986

Merged
merged 9 commits into from
Nov 15, 2023

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Nov 14, 2023

Description

Includes changes in #14984, please merge that one before

Code frame was not generated for PostCSS errors. This PR fixes that and reverts #6293 as it's now handled inside the plugin.
Also this PR fixes a bug that the caret position was not correct for PostCSS errors/warnings. PostCSS uses 1-based column unlike our generateCodeFrame.

I tested this PR with #5647 and #4667.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added feat: css p3-minor-bug An edge case that only affects very specific usage (priority) labels Nov 14, 2023
patak-dev
patak-dev previously approved these changes Nov 14, 2023
@patak-dev patak-dev merged commit bedfcfa into vitejs:main Nov 15, 2023
11 checks passed
@sapphi-red sapphi-red deleted the fix/postcss-error-handling branch November 15, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: css p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants