build: handle latest json-stable-stringify replacement #15049
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the recent version (
v1.1.0
) of thejson-stable-stringify
module, caching ofJSON.stringify
was implemented.The syntax changed from:
to:
Vite optimized the
json-stable-stringify
module and in its transform phase it matched a regular expression for thejsonify
module, which caused build failures due to changes in syntax.The original regex pattern was:
/^var json = typeof JSON.+require\('jsonify'\);$/gm
I personally think that there is no need to consider how the submodule of itself is dependent on by the
json-stable-stringfy
module, just replacing its own submodule withJSON
can achieve expectations.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).