Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: handle latest json-stable-stringify replacement #15049

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

XiSenao
Copy link
Collaborator

@XiSenao XiSenao commented Nov 20, 2023

Description

In the recent version (v1.1.0) of the json-stable-stringify module, caching of JSON.stringify was implemented.

The syntax changed from:

var json = typeof JSON !== 'undefined' ? JSON : require('jsonify');

to:

var jsonStringify = (typeof JSON !== 'undefined' ? JSON : require('jsonify')).stringify;

Vite optimized the json-stable-stringify module and in its transform phase it matched a regular expression for the jsonify module, which caused build failures due to changes in syntax.

The original regex pattern was:

/^var json = typeof JSON.+require\('jsonify'\);$/gm

I personally think that there is no need to consider how the submodule of itself is dependent on by the json-stable-stringfy module, just replacing its own submodule with JSON can achieve expectations.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy changed the title fix: update dependency modules build: handle latest json-stable-stringify replacement Nov 22, 2023
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bluwy bluwy merged commit bcc4a61 into vitejs:main Nov 22, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants