fix(define): allow define process.env #15173
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #15164
Allow
define
to override whatprocess.env
replaces, same as Vite 4. It works before because we replace things like this instead: https://github.com/vitejs/vite/pull/11151/files#diff-d90a7c21c9fb9222e557704bd906ea5671d5fe384c8fb105459eea8c36fdb4f0L22-R23Additional context
Personally I don't think this is a good pattern in general, but I suppose it doesn't hurt to support it for now.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).