-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 🧪 chunkMap #15373
base: main
Are you sure you want to change the base?
feat: 🧪 chunkMap #15373
Conversation
Run & review this pull request in StackBlitz Codeflow. |
20dfec4
to
46a8ae1
Compare
a8bc4cd
to
392f959
Compare
I wanted to surface a couple of comments about this PR over in the SvelteKit repo that reviewers should probably be aware of: sveltejs/kit#11615 (comment) |
2a3ff35
to
72e913b
Compare
Thanks for working on this issue, I've tried it on my actual app and:
Not sure if that's the problem that needs to be fixed in vite or in the PWA plugin |
Thank you for checking ✨ |
Thanks for testing @jacekkarczmarczyk! cc @userquin in case this rings a bell |
I've build first with |
I've rebased PR branch against the current |
I've tested it also with legacy plugin (5.3.0), and all chunks have new hashes, I think it's fine for legacy chunks (old browsers don't support import maps I guess, although it could use System.js, not a big issue though) but modern ones should not be changed. Not sure if I'm going to use legacy plugin after switching to vite, just letting you know. |
8f3778e
to
1616060
Compare
I've experimented with applying this POC to our large vite app, and it works brilliantly! |
2352c99
to
9d4dc45
Compare
for Production: #16552
Proof of Concept Implementation for #15372
This PR shows that ChunkMap (to avoid cascading cache invalidation problem with importmap) can be implemented seamlessly without impact on existing systems.