feat(resolve): auto externalize node builtins for noExternal: true in node

[bluwy]

Description

In this PR, when setting ssr.noExternal: true and ssr.target: 'node' (default), node builtins will be auto-externalized. Without this PR, it'll error that Cannot bundle Node.js built-in "node:http" imported from .... Consider disabling ssr.noExternal or remove the built-in dependency., which I think is odd because we know we're building for node, and it's safe to auto-externalize by default.

This feature was added long ago in #4490 for webworkers. And there's also workarounds by setting node builtins in ssr.external manually yourself. But I figured to kick off this idea since it feels like a safe default.

Additional context

Found this while reviewing withastro/astro#10202. I figured for users who build to node and want to bundle everything, we can suggest ssr.noExternal: true only and it'll work, otherwise they need to workaround setting builtins in ssr.external manually.

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines, especially the Pull Request Guidelines.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Update the corresponding documentation if needed.
• Ideally, include relevant tests that fail without this PR but pass with it.

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[acoderacom]

just update to 5.2.2 but still got error
12:57:19 AM: Error [RollupError]: [commonjs--resolver] Cannot bundle Node.js built-in "node:crypto" imported from "node_modules/@remix-run/node/dist/sessions/fileStorage.js". Consider disabling ssr.noExternal or remove the built-in dependency.

[bluwy]

Can you open a new issue and repro for it? I'm pretty sure this PR is working correctly

[acoderacom]

no worry, I was able to fix it. Thank you

[jjenzz]

@acoderacom how did you fix it? i have the same issue.

[acoderacom]

@jjenzz Are you using remix with netlify? no?

[jjenzz]

@acoderacom yes, i was using the netlify edge template and later realised that it relies on deno runtime.

[acoderacom]

@jjenzz you need to use @netlify/remix-runtime

[jjenzz]

@acoderacom yeah, i did but other packages still complained. i raised the issue in remix discord and netlify introduced a fix here yday tho 🙌 netlify/remix-compute#317