chore(deps): update @shikijs/vitepress-twoslash to 1.5.0 #16637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
It looks like the code examples now look indented though, I think we want to dedent it? 
|
sapphi-red
reviewed
May 9, 2024
docs/config/build-options.md
Outdated
Comment on lines
51
to
64
| ```js twoslash | ||
| /** @type {import('vite').UserConfig} */ | ||
| const config = { | ||
| build: { | ||
| // ---cut-before--- | ||
| modulePreload: { | ||
| resolveDependencies: (filename, deps, { hostId, hostType }) => { | ||
| return deps.filter(condition) | ||
| }, | ||
| }, | ||
| // ---cut-after--- | ||
| // ---cut-before--- | ||
| modulePreload: { | ||
| resolveDependencies: (filename, deps, { hostId, hostType }) => { | ||
| return deps.filter(condition) | ||
| }, | ||
| }, | ||
| // ---cut-after--- | ||
| }, | ||
| } | ||
| ``` |
There was a problem hiding this comment.
Ah, I forgot about dedenting when implementing twoslashes/twoslash#33 😅. I noticed that we can simply this by putting the prettier-ignore inside.
/** @type {import('vite').UserConfig} */
const config = {
// prettier-ignore
build: {
// ---cut-before---
modulePreload: {
resolveDependencies: (filename, deps, { hostId, hostType }) => {
return deps.filter(condition)
},
},
// ---cut-after---
},
}
|
@bluwy Adjusted according to @sapphi-red 's suggestion, now there is no indentation. But now there is no scene with a space before the cut comment. 😃 |
bluwy
approved these changes
May 10, 2024
patak-dev
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
twoslashes/twoslash#33 Implemented twoslash to support adding spaces in front of cut comments, so
<!-- prettier-ignore-start -->can be removed.