fix(importMetaGlob): handle alias that starts with hash #17743
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #17614
ref #12467
The
importMetaGlob
logic always assumed globs that starts with#
are subpath imports, and so the resolved path is relative and should join to the root. However, aliases that starts with#
could resolve too, which returns an absolute path.Due to the previous assumption, the root and absolute path was joined, causing an invalid path for globbing.
This PR fixes it by returning the subpath imports resolved path as absolute instead, preventing the need for any special handling. This means the
pre + globSafeResolvedPath(resolved, glob)
part also gets executed for subpath imports, which I think it's more correct and handles the edge cases there.