Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(css)!: change default sass api to modern/modern-compiler #17937

Merged
merged 11 commits into from
Oct 25, 2024

Conversation

hi-ogawa
Copy link
Collaborator

@hi-ogawa hi-ogawa commented Aug 24, 2024

Description

Changing the default api for Vite 6 as described in #17728 (comment)

todo

Copy link

stackblitz bot commented Aug 24, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@hi-ogawa hi-ogawa changed the title feat!(css): change default sass api to modern/modern-compiler feat(css)!: change default sass api to modern/modern-compiler Aug 24, 2024
@sapphi-red
Copy link
Member

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

📝 Ran ecosystem CI on 27bd441: Open

suite result latest scheduled
astro failure failure
nuxt failure success
redwoodjs failure failure
remix failure failure
sveltekit failure failure
vike failure failure
vite-plugin-svelte failure failure
vitest failure failure

analogjs, histoire, ladle, laravel, marko, previewjs, quasar, qwik, rakkas, storybook, unocss, vite-environment-examples, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-swc, vite-plugin-vue, vite-setup-catalogue, vitepress, vuepress

sapphi-red
sapphi-red previously approved these changes Oct 25, 2024
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the docs a bit. LGTM!

@sapphi-red sapphi-red merged commit d4e0442 into vitejs:main Oct 25, 2024
14 checks passed
@hi-ogawa hi-ogawa deleted the feat-change-default-sass-api branch October 25, 2024 07:53
net7toulouse pushed a commit to inp-net/churros that referenced this pull request Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change p3-significant High priority enhancement (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants