test: test ModuleRunnerTransport invoke API
#18865
Merged
+148
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dario-piotrowicz
force-pushed
the
dario/runner-transport-invoke-test
branch
from
fcbd6db to
8c6af6e
Compare
dario-piotrowicz
force-pushed
the
dario/runner-transport-invoke-test
branch
from
8c6af6e to
bf534db
Compare
sapphi-red
reviewed
Dec 3, 2024
packages/vite/src/node/ssr/runtime/__tests__/server-worker-runner.invoke.spec.ts
Outdated
Show resolved
Hide resolved
use different broadcast channel name Co-authored-by: sapphi-red <49056869+sapphi-red@users.noreply.github.com>
use birpc to avoid relying on internal structure of invoke
simplify and improve tests
remove unnecessary assertion
simplify worker code
remove extra finally
|
Thanks for the change 💚 While trying this PR locally, I found a bug in the previous PR and made a fix for it (#18876). 72ee49b: set the return value of invoke on the main thread side as it will be called from the worker side, also made the successful case to use The tests should pass after #18876 is merged. |
|
Thanks a lot for the changes @sapphi-red 🙏 |
sapphi-red
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding a test for the
invokemethod of theModuleRunnerTransportFollowup from: #18851