Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): recreate ssrCompatModuleRunner on restart #18973

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Dec 16, 2024

Description

fixes #18962
refs #18784

It will be recreated here:

server._ssrCompatModuleRunner ||= new SSRCompatModuleRunner(environment)

@sapphi-red sapphi-red added p3-minor-bug An edge case that only affects very specific usage (priority) feat: ssr regression The issue only appears after a new release labels Dec 16, 2024
@sapphi-red sapphi-red changed the title fix(ssr): recrete ssrCompatModuleRunner on restart fix(ssr): recreate ssrCompatModuleRunner on restart Dec 16, 2024
@patak-dev patak-dev merged commit 7d6dd5d into vitejs:main Dec 16, 2024
21 checks passed
@sapphi-red sapphi-red deleted the fix/ssr-recreate-ssr-compat-module-runner-on-restart branch December 17, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: ssr p3-minor-bug An edge case that only affects very specific usage (priority) regression The issue only appears after a new release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite module runner has been closed
3 participants